Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: move IT in executor to tests/integrationtest (PART 9) #48179

Merged
merged 9 commits into from
Nov 2, 2023
Merged

tests: move IT in executor to tests/integrationtest (PART 9) #48179

merged 9 commits into from
Nov 2, 2023

Conversation

Defined2014
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #47076

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 1, 2023
@tiprow tiprow
Copy link

tiprow bot commented Nov 1, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2023 •
edited
Loading

Codecov Report

Merging #48179 (4449e87) into master (d380ef4) will increase coverage by 1.3049%.
Report is 20 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #48179        +/-   ##
================================================
+ Coverage   71.5266%   72.8316%   +1.3049%     
================================================
  Files          1400       1425        +25     
  Lines        406057     412667      +6610     
================================================
+ Hits         290439     300552     +10113     
+ Misses        95783      93236      -2547     
+ Partials      19835      18879       -956
Flag Coverage Δ
integration 42.9608% <ø> (?)
unit 71.5218% <ø> (-0.0048%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9874% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7021% <ø> (-4.1963%) ⬇️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 1, 2023
@Defined2014
Copy link
Contributor Author

@SeaRise @YangKeao PTAL

@Defined2014
Copy link
Contributor Author

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 2, 2023

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

YangKeao
YangKeao approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hawkingrei, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YangKeao,hawkingrei]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 2, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-01 09:36:18.44172702 +0000 UTC m=+3032176.028837150: ☑️ agreed by hawkingrei.
  • 2023-11-02 09:18:03.515348157 +0000 UTC m=+3117481.102458302: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot merged commit c3282e3 into pingcap:master Nov 2, 2023
12 of 16 checks passed
@Defined2014 Defined2014 deleted the move-executor-part9 branch November 14, 2023 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangKeao YangKeao YangKeao approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@SeaRise SeaRise Awaiting requested review from SeaRise

@xhebox xhebox Awaiting requested review from xhebox

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Defined2014 @hawkingrei @YangKeao